-
Notifications
You must be signed in to change notification settings - Fork 0
add end date #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add end date #15
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an optional endDate parameter to allow users to specify when their semester or quarter ends, providing more control over recurring event scheduling. Previously, events would always recur for a fixed 16-week period from the start date.
Key changes:
- Added
endDateoptional parameter to the calendar event creation functions - Updated UI to include an end date picker below the start date picker
- Modified sessionStorage handling to persist the end date across page reloads
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/server/services/google-calendar.ts | Added endDate optional parameter to addEventsToCalendar and createRecurringEvent functions, using it as the last occurrence date if provided |
| src/server/api/routers/schedule.ts | Added endDate to input schemas for both generateIcal and syncToGoogleCalendar procedures, passing it through to underlying functions |
| src/components/upload-zone.tsx | Added end date state management, sessionStorage persistence, new calendar picker UI component, and updated mutation calls to include endDate |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 0a06192.
No description provided.